-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Vietnam and Ho Chi Minh #23
base: main
Are you sure you want to change the base?
Conversation
… asia/README.md and in Vietnam/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect! Follow the suggested changes to get this merged on the travel guide!
@@ -0,0 +1,6 @@ | |||
Some of my family is there and I miss the street food. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page needs a title!
There are better fruits there, such as dragon fruits | ||
and, most importantly, durian. | ||
|
||
More information at [Ho Chi Minh](https://en.wikipedia.org/wiki/Ho_Chi_Minh_City) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hyperlink should be informative, for example something like "ho chi Minh wikipedia" or plainly "wikipedia".
@@ -0,0 +1,3 @@ | |||
More information at [Vietnam](https://en.wikipedia.org/wiki/Vietnam) | |||
|
|||
[Ho Chi Minh](./Ho_CHi_Minh.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file has similar issues than the other one, title and meaningful link description.
Added appropriate files and links. Please review and consider visiting Vietnam.
Answers UCL-COMP0233-24-25/RSE-Classwork#3