Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Vietnam and Ho Chi Minh #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DanielChau128
Copy link

Added appropriate files and links. Please review and consider visiting Vietnam.

Answers UCL-COMP0233-24-25/RSE-Classwork#3

Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect! Follow the suggested changes to get this merged on the travel guide!

@@ -0,0 +1,6 @@
Some of my family is there and I miss the street food.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page needs a title!

There are better fruits there, such as dragon fruits
and, most importantly, durian.

More information at [Ho Chi Minh](https://en.wikipedia.org/wiki/Ho_Chi_Minh_City)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hyperlink should be informative, for example something like "ho chi Minh wikipedia" or plainly "wikipedia".

@@ -0,0 +1,3 @@
More information at [Vietnam](https://en.wikipedia.org/wiki/Vietnam)

[Ho Chi Minh](./Ho_CHi_Minh.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has similar issues than the other one, title and meaningful link description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants