Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shangyu is adding kenya to the guide #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EzAubergine
Copy link

Adding interesting destinations in Kenya to the travel guide

Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good in terms of links, but it doesn't follow the structure of other guides in the travel guide. Follow the suggestions to fix these.
Also, don't forget to refer to the issue as instructed on the body of the PR.

@@ -1,3 +1,3 @@
# AFRICA

Go to [Kenya readme](./kenya/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to say "readme" in the hyperlink, it's better if set as a bullet point as the top-level README file.

@@ -0,0 +1 @@
See the [destinations](./destinations.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page misses an index: # Kenya
Rather than have a destinations page, make that as a section in this file linking to different of them, e.g., Nairobi

Comment on lines +3 to +5
## 01. Nairobi National Park
- Great for wildlife exploration
- Read more at [wikipedia](https://en.wikipedia.org/wiki/Nairobi_National_Park)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deserves a page in itself: kenya/nairobi.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants