-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shangyu is adding kenya to the guide #35
base: main
Are you sure you want to change the base?
Shangyu is adding kenya to the guide #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good in terms of links, but it doesn't follow the structure of other guides in the travel guide. Follow the suggestions to fix these.
Also, don't forget to refer to the issue as instructed on the body of the PR.
@@ -1,3 +1,3 @@ | |||
# AFRICA | |||
|
|||
Go to [Kenya readme](./kenya/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to say "readme" in the hyperlink, it's better if set as a bullet point as the top-level README file.
@@ -0,0 +1 @@ | |||
See the [destinations](./destinations.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page misses an index: # Kenya
Rather than have a destinations page, make that as a section in this file linking to different of them, e.g., Nairobi
## 01. Nairobi National Park | ||
- Great for wildlife exploration | ||
- Read more at [wikipedia](https://en.wikipedia.org/wiki/Nairobi_National_Park) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deserves a page in itself: kenya/nairobi.md
Adding interesting destinations in Kenya to the travel guide