Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mengyu liu feature #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

echolmy
Copy link

@echolmy echolmy commented Oct 7, 2024

Add a page that describes why you want to travel to Canary Islands

Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect. There are some requirements to make it so.
Note, however, that something else has already contributed this location, so I'd suggest providing some extra updates to what's been added.

Don't forget to refer to the issue as instructed in the body of your PR.

@@ -2,6 +2,7 @@
- [AFRICA](./africa/README.md)
- [ASIA](./asia/README.md)
- [EUROPE](./europe/README.md)
[Spain](./europe/spain/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should be in the europe/README.md file, not in here.

@@ -0,0 +1 @@
[canary_islands](./europe/spain/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page misses a title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants