Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests practice in week 2 #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

I-Choose-A
Copy link

@I-Choose-A I-Choose-A commented Oct 7, 2024

add some info about Spain and the Canary Islands

Answers UCL-COMP0233-24-25/RSE-Classwork#3

@I-Choose-A
Copy link
Author

add some info about Spain and the Canary Islands

Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires a bit of work.
Note that beyond of what's suggested below, this location is already on the guide, and you'll have some merge conflicts to fix.


The seven main islands are, from largest to smallest in area, Tenerife, Fuerteventura, Gran Canaria, Lanzarote, La Palma, La Gomera, and El Hierro. The only other populated island is La Graciosa, which administratively is dependent on Lanzarote. The archipelago includes many smaller islands and islets, including Alegranza, Isla de Lobos, Montaña Clara, Roque del Oeste, and Roque del Este. It includes a number of rocks, including Garachico and Anaga. In ancient times, the island chain was often referred to as "the Fortunate Isles".[7] The Canary Islands are the southernmost region of Spain, and the largest and most populous archipelago of Macaronesia.[8] Because of their location, the Canary Islands have historically been considered a link between the four continents of Africa, North America, South America, and Europe.[9]

[link in wiki] https://en.wikipedia.org/wiki/Canary_Islands
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is not following the markdown syntax. Saying "link" in a link is redundant.

@@ -1 +1,2 @@
# EUROPE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses the links from Europe to Spain, and from Spain to Canary Islands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants