Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination: Engleberg added #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

l-buhil
Copy link

@l-buhil l-buhil commented Oct 7, 2024

The place added to travel guide is Engleberg, Switzerland with a link to Wikipedia and adjusted the README files to lead to Engleberg

Copy link
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect, some minimum changes.
Please, also refer in the body of the PR to the issue as instructed.

@@ -0,0 +1,2 @@
places here:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this page misses the title


I would like to go to Engleberg (a small vilage in the Swiss alps) as it's surrounded by so much open space, the huge alps, and is so differnt to the landscape in England. It's breath taking.

More info at [wikipeadia] (https://en.wikipedia.org/wiki/Engelberg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space

Suggested change
More info at [wikipeadia] (https://en.wikipedia.org/wiki/Engelberg)
More info at [wikipeadia](https://en.wikipedia.org/wiki/Engelberg)

@@ -1 +1,3 @@
# EUROPE
Places:
[Switzerland](./Switzerland/README.MD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be consistent with the extensions, md in lower case, please 😁

@@ -1 +1,3 @@
# EUROPE
Places:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add this line, the below could be set as a bullet point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants