-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SurfacePhasors class #205
Merged
Merged
SurfacePhasors class #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly I want more doc comments from you, old bean.
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
…nto wgraham-surface_phasors_class
Co-authored-by: Sam Cunliffe <samcunliffe@users.noreply.github.com>
…nto wgraham-surface_phasors_class
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #63 |
SurfacePhasor
classAdds a class that handles the complex amplitude extraction across the user-specific surface in
iterator.cpp
.Removes a data clump (
surface_EH{r,i}
,surface_vertices
,vertex_list
and other associated variables) and groups together what were previously a collection of standalone functions.Also adds a destructor for this class so memory cleanup is automatic, rather than having to be called manually around line 4620.
Extensions
I suspect either this class or a very similar one can also be used to remove the data clump associated to the complex amplitude extraction at the user-specified vertices. We may even be able to directly generalise the
SurfacePhasor
class into aPhasorExtraction
super-class or something...