Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurfacePhasors class #205

Merged
merged 24 commits into from
Dec 22, 2022
Merged

SurfacePhasors class #205

merged 24 commits into from
Dec 22, 2022

Conversation

willGraham01
Copy link
Collaborator

Continues #63 |

SurfacePhasor class

Adds a class that handles the complex amplitude extraction across the user-specific surface in iterator.cpp.

Removes a data clump (surface_EH{r,i}, surface_vertices, vertex_list and other associated variables) and groups together what were previously a collection of standalone functions.

Also adds a destructor for this class so memory cleanup is automatic, rather than having to be called manually around line 4620.

Extensions

I suspect either this class or a very similar one can also be used to remove the data clump associated to the complex amplitude extraction at the user-specified vertices. We may even be able to directly generalise the SurfacePhasor class into a PhasorExtraction super-class or something...

Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly I want more doc comments from you, old bean.

tdms/include/arrays.h Outdated Show resolved Hide resolved
tdms/include/arrays.h Show resolved Hide resolved
tdms/include/arrays.h Show resolved Hide resolved
tdms/include/surface_phasors.h Outdated Show resolved Hide resolved
tdms/include/surface_phasors.h Outdated Show resolved Hide resolved
tdms/include/surface_phasors.h Outdated Show resolved Hide resolved
tdms/src/surface_phasors.cpp Outdated Show resolved Hide resolved
tdms/src/surface_phasors.cpp Outdated Show resolved Hide resolved
tdms/src/surface_phasors.cpp Outdated Show resolved Hide resolved
tdms/tests/unit/array_tests/test_FullFieldSnapshot.cpp Outdated Show resolved Hide resolved
Base automatically changed from wgraham-refactor_iterator_3 to main December 21, 2022 09:04
@willGraham01 willGraham01 merged commit bda025b into main Dec 22, 2022
@willGraham01 willGraham01 deleted the wgraham-surface_phasors_class branch December 22, 2022 11:59
@willGraham01 willGraham01 mentioned this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants