Locally disable pylint E0110 as false positive #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor to use ExcelWriter as context manager as recommended in docs
tamuri
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1181.
The E0110 (abstract-class-instantiated) violation flagged by Pylint by instantiating
pandas.ExcelWriteris a false positive (pylint-dev/pylint#3060), so this PR locally disables the rule at this usage.Also refactors to use
pandas.ExcelWriteras context manager as recommended in docs, which incidentally fixes aE1101: Instance of 'ExcelWriter' has no 'save' member; maybe '_save'? (no-member)Pylint violation (docs seem to suggestcloseis an alias ofsavebut don't specifically documentsavesuggesting it may not be an intended part of API) and removes global ignore of E0110 inpyproject.toml.