Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect use of raise with warnings.warn in scenario switcher #1196

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

matt-graham
Copy link
Collaborator

Part of #1181.

Fixes an incorrect use of raise statement with a call to warnings.warn (raise should be used with an Exception subtype while the recommended approach for outputting warnings is to call warnings.warn). Also removes the global Pylint E0702 rule ignore from pyproject.toml that flags this previous usage as a violation.

@matt-graham matt-graham requested a review from tamuri November 14, 2023 17:31
@matt-graham matt-graham merged commit f64c18b into master Nov 28, 2023
55 checks passed
@matt-graham matt-graham deleted the mmg/fix-raise-warnings-warn branch November 28, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants