Allow declaring and retriveing names associated with draws in the Scenario class
#1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamuri
reviewed
Sep 26, 2024
tamuri
reviewed
Nov 4, 2024
| def draw_name(self, draw_number) -> str: | ||
| """Returns the name of the draw corresponding to the given draw number. This is offered for convenience so that | ||
| the logfile contain a 'user-friendly' label for the draw.""" | ||
| return "" |
There was a problem hiding this comment.
Can the default be this instead?
Suggested change
| return "" | |
| return str(draw_number) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1451
This line can be added to the
Scenarioclass:and in the analysis script, the draw_names can be retrieved using
Optionally, the existing
extract_parametersfunction can index the parameters being changes by these same draw names.