Move from Dropbox to Sharepoint (Consumable scripts) #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 4, 2024 19:16
- note that the location of the files in sharepoint has also been changed
- the units per case are now hard coded in the script - the unit cost is in ResourceFile_costing.xlsx
|
@tbhallett Should I also drop the |
sakshimohan
commented
Sep 5, 2024
| @@ -339,7 +339,7 @@ def check_format_of_consumables_file(df, fac_ids): | |||
| months = set(range(1, 13)) | |||
| item_codes = set(df.item_code.unique()) | |||
|
|
|||
| assert set(df.columns) == {'Facility_ID', 'month', 'item_code', 'available_prop'} | |||
| assert set(df.columns) == {'Facility_ID', 'month', 'item_code', 'item_category', 'available_prop'} | |||
There was a problem hiding this comment.
@tbhallett I have updated the check_format_of_consumables_file function to include a check for item_category. This refers to a cleaned categorisation of item_codes into programs or categories, such as "general" consumables. I use this columns to make regression based projections in PR #1367 as it's useful to have for costing plots.
Is this OK?
sakshimohan
pushed a commit
that referenced
this pull request
Sep 6, 2024
- this is due to changes in PR #1458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the locations of raw consumables files from dropbox to the new sharepoint folder.
In addition, the following updates are made -
ResourceFile_Consumables_availability_small.csv. This information is used in certain scripts (plotting cost estimates, predicting availability for consumable scenarios) - Previously this was taken from the large consumable availabilityResourceFile_Consumables_availability_and_usage.csvdescriptive_stats.py,clean_fac_locations.pyUnits per caseandUnit_Costare dropped fromResourceFile_Consumables_Items_and_Packages.csv(Following Issue Remove deprecated concept of Consumables Packages #1303)
Pending tasks
ResourceFile_Consumables_Items_and_Packages.csvso that the definitions are all in one placeIntervention_Pkg_Codealso needs to be dropped fromResourceFile_Consumables_Item_Designations.csv