Remove hardcoded reference to simulation years preventing simulations being ran with a start date after 2010 #1486
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… simulation starts after 2018
… starts after 2010" This reverts commit c3433da.
tdm32
reviewed
Oct 10, 2024
tdm32
reviewed
Oct 10, 2024
| @@ -182,7 +182,10 @@ def initialise_simulation(self, sim): | |||
| sim.schedule_event(EpiLoggingEvent(self), sim.date + DateOffset(years=1)) | |||
|
|
|||
| # HPV vaccine given from 2018 onwards | |||
| sim.schedule_event(HpvScheduleEvent(self), Date(2018, 1, 1)) | |||
| if self.sim.date.year < 2018: | |||
matt-graham
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
These look like sensible changes to me and as @tdm32 has approved and tests are passing I would say this is good to merge unless @tbhallett wants to do a final review first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR edits two modules which have hard coded reference to years in the simulation prevent running of a simulation with a start date after a given year. Therefore running the simulation with a start date later that these years causes the model to crash. This is mainly relevant to attempts to use the model in a cohort mode.
@tdm32 have requested your review as its two of your modules. please let me know if you'd like me to change what i've got here.