Remove population-wide HSI event in ChronicSyndrome module #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-graham
reviewed
Nov 5, 2024
There was a problem hiding this comment.
With regards to #1260 - would the plan be to remove the logic in the health system scheduler for processing population scoped HSI events in a separate PR? It might also be good to add some logic to HSI_Event or PopulationScopeEventMixin in such a PR that raises an error when trying to subclass from both if so to ensure we fail loudly on trying to instantiate a population-scoped HSI event.
| @@ -214,11 +214,11 @@ def initialise_simulation(self, sim): | |||
| self.sim.schedule_event(outreach_event, self.sim.date + DateOffset(months=6)) | |||
|
|
|||
| # Schedule the occurance of a population wide change in risk that goes through the health system: | |||
There was a problem hiding this comment.
Suggested change
| # Schedule the occurance of a population wide change in risk that goes through the health system: | |
| # Schedule the occurrence of a population wide change in risk: |
Possibly remove the reference to health system in comment as no longer a HSI event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in Issue #1260, our assumptions around how the healthsystem handles resource constraints does not allow for the use of Population-wide HSI events. Here we remove one such instance from the mock ChronicSyndrome module used by some of the HealthSystem tests.