Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[URGENT] Chat Markdown crashes on some input #127

Closed
zjkmxy opened this issue Aug 4, 2024 · 3 comments · Fixed by #128
Closed

[URGENT] Chat Markdown crashes on some input #127

zjkmxy opened this issue Aug 4, 2024 · 3 comments · Fixed by #128
Labels
bug Something isn't working

Comments

@zjkmxy
Copy link
Collaborator

zjkmxy commented Aug 4, 2024

Steps to reproduce:
(1) Input the following text in the chat box

`code`

(2) Click the Send button
(3) The chat message is not sent. The following error shown in the console:

TypeError: Cannot read properties of undefined (reading 'inTable')
    at Object.exitCodeText (index.js:123:17)
    at compile (index.js:363:40)
    at fromMarkdown (index.js:193:30)
    at parser (index.js:18:12)
    at Function.parse (index.js:273:12)
    at Object.fn (dev.jsx:310:50)
    at runComputation (dev.js:720:22)
    at updateComputation (dev.js:702:3)
    at createMemo (dev.js:263:10)
    at SolidMarkdown (dev.jsx:299:24)

Environment: Edge 127.0.2651.86

@zjkmxy zjkmxy added the bug Something isn't working label Aug 4, 2024
@zjkmxy
Copy link
Collaborator Author

zjkmxy commented Aug 4, 2024

@AnoldGH Please fix and run a full test on input.

@AnoldGH
Copy link
Contributor

AnoldGH commented Aug 4, 2024

The error was introduced by specifying remark-gfm version 4.0.0 instead of 3.0.1 in package.json. I accidentally overwrote the dependencies before pushing, apology. I will fix it quickly.

@zjkmxy
Copy link
Collaborator Author

zjkmxy commented Aug 4, 2024

The error was introduced by specifying remark-gfm version 4.0.0 instead of 3.0.1 in package.json. I accidentally overwrote the dependencies before pushing, apology. I will fix it quickly.

Oh, that was introduced when I resolved the conflict. Don't know why but let me merge your fix.

zjkmxy added a commit that referenced this issue Aug 4, 2024
Change remark-gfm version to 3.0.1

Fix: #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants