Fix more Codacy warnings

UCLALibrary · Mar 8, 2024 · 8d8db18 · 8d8db18
1 parent 845b4cc
commit 8d8db18
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/main/java/edu/ucla/library/iiif/fester/CsvParser.java b/src/main/java/edu/ucla/library/iiif/fester/CsvParser.java
@@ -432,6 +432,7 @@ private String[] checkApiCompatibility(final String[] aRow, final Path aPath, fi
      * @throws CsvParsingException If object type isn't included in the CSV headers, or the object type index is out of
      *         bounds of the CSV row, or the metadata contains an unknown object type
      */
+    @SuppressWarnings("PMD.NPathComplexity")
     public static ObjectType getObjectType(final String[] aRow, final CsvHeaders aCsvHeaders)
             throws CsvParsingException {
         if (aCsvHeaders.hasIiifObjectTypeIndex()) {
@@ -486,9 +487,11 @@ public static ObjectType getObjectType(final String[] aRow, final CsvHeaders aCs
         if (ObjectType.PAGE.equals(objectType)) {
             return ObjectType.PAGE;
         }
-        if (ObjectType.MISSING.equals(StringUtils.trimTo(objectType, Constants.EMPTY))) {
+
+        if (ObjectType.MISSING.equals(StringUtils.trimTo(objectType, EMPTY))) {
             return ObjectType.MISSING;
         }
+
         // Disallow unknown types
         throw new CsvParsingException(MessageCodes.MFS_094, objectType);
     }

diff --git a/src/main/java/edu/ucla/library/iiif/fester/verticles/V2ManifestVerticle.java b/src/main/java/edu/ucla/library/iiif/fester/verticles/V2ManifestVerticle.java
@@ -452,6 +452,7 @@ private void updatePages(final Message<JsonObject> aMessage) throws JsonProcessi
      * @param aSequence A sequence to add pages to
      * @param aImageHost An image host for image links
      * @param aWorkID A URL encoded work ID
+     * @return An array of canvases
      * @throws IOException If there is trouble adding a page
      */
     @SuppressWarnings({ "PMD.CyclomaticComplexity", "PMD.NcssCount" })