Attempted to add Bootstrap to app #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k.config.js, imported bootstrap.css in main.js
EdwardReed
reviewed
Jul 28, 2017
| @@ -1,10 +1,9 @@ | |||
| var React = require('react'); | |||
| var styles = require('./App.css'); | |||
There was a problem hiding this comment.
Let's continue to use this line to require our styles for the app.
EdwardReed
reviewed
Jul 28, 2017
| @@ -1,5 +1,7 @@ | |||
| import React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
| import App from './App.js'; | |||
| import Bootstrap from './bootstrap/dist/css/bootstrap.css' | |||
EdwardReed
reviewed
Jul 28, 2017
| @@ -6,6 +6,7 @@ | |||
| <title>Zero Waste</title> | |||
| <meta name="description" content="We're reaching zero waste... and having fun doing it"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <link rel = "stylesheet" href="bootstrap/dist/css/bootstrap.css"> | |||
There was a problem hiding this comment.
Remove Line -Webpack will handle all of our assets (CSS/JS) for the app.
|
@Noewel In most of our files JS/CSS we should be able to require or import require styles and libs. Take a look at facebook/create-react-app#301 (comment) So adding the bootstrap repo isn't required. |
EdwardReed
reviewed
Jul 28, 2017
| @@ -1,10 +1,9 @@ | |||
| var React = require('react'); | |||
| var styles = require('./App.css'); | |||
| var styles = require('./bootstrap/dist/css/bootstrap.css'); | |||
There was a problem hiding this comment.
See facebook/create-react-app#301 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installed file-loader and url-loader dependencies, Added loaders to webpack.config.js, Imported bootstrap into main.js. I downloaded the compiled and minified CSS, JavaScript, and fonts from getbootstrap.com and dropped them into the app folder(Not entirely sure if this was necessary; probably why there are so many changed files).