Ctrl c exception handling #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyboardInterupt exceptions added to try-except blocks. addition of assertions for checkVerbose
Moved KeyboardInterrupt exception before BaseException. Also added second "r" in "interrupt."
- also noticed a resampling typo that was deprecated due to the use of resampling rather than just downsampling
just for the only try-except block that needs it.
sprestrelski
requested changes
Feb 28, 2023
There was a problem hiding this comment.
Both the system exits work for Microfaune and TweetyNet! Would you be able to implement this functionality for BirdNET as well? You may need to look into the birdnet_lite/analyze.py script as interrupting from generate_automated_labels may not stop the process. I would check out what the behavior currently looks like when trying (and failing) a KeyboardInterrupt, then tracing where the error message comes from.
purovida94
reviewed
Mar 1, 2023
There was a problem hiding this comment.
@sprestrelski I added in some KeyboardInterrupt exceptions in to analyze.py. they're working on my end, let me know if they're working for you too. Gracias!
purovida94
approved these changes
Mar 1, 2023
|
Merged, thanks Teo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in more predictable behavior when processing large datasets, allowing a user to stop the process via Ctrl-C