Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Matching and FG-BG Separation #192

Merged
merged 10 commits into from
May 5, 2024
Merged

Conversation

TQZhang04
Copy link
Contributor

Adds functionality for template matching and reverse-engineered BirdNET FG-BG Separation techniques.

JacobGlennAyers and others added 9 commits January 4, 2024 13:56
…l Score Generation technique

- Added in some additional bug fixes related to threshold mins in some of the isolation techniques
- Added a modification to the Jupyter notebook tutorial to include the new technique, make sure to change it back before pushing to main
- Fixed a threshold min bug in steinberg isolate
- still need to do docstrings on added functions
- will need to change the PyHa tutorial back to Microfaune
- will need to update the readme
- will need to run all of the other techniques again to verify I didn't break anything
- addressed threshold min handling when key isn't used by user
- Added back in try-catch block when generating local score arrays
- Demonstrated in tutorial notebook
- added into IsoAutio
- Handled in annotation_chunker()
First pass of confidence column from max local score array values
Added descriptions of isolation parameters for template matching and FG-BG
Updated IsoAutio.py documentation with descriptions of write_confidence and template matching/FG-BG functions
…iles

Added descriptions of the util.py files for template matching and BirdNET FG-BG Separation
@TQZhang04 TQZhang04 requested a review from JacobGlennAyers May 4, 2024 22:11
Copy link
Contributor

@JacobGlennAyers JacobGlennAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New documentation looks good, need to double-check the tutorial, which I tend to leave as the Microfaune default

@JacobGlennAyers
Copy link
Contributor

@TQZhang04 I think there are only 2 more things to work through here. First, I notice that the demonstrations I had of template matching and foreground-background separation in the tutorial jupyter notebook did carry over, but I would leave the default as Microfaune to keep things consistent. Furthermore, could you maybe discuss with Sean, Sam, and Nathan the nature of all these environment checks with github actions? I think that someone broke the path of the Screaming Piha example dataset that is configured somewhere in github actions. It would be nice if those are all green before we push to main.

@ntlhui
Copy link
Contributor

ntlhui commented May 5, 2024

Please update this branch with latest changes from main - the environment tests do not need to be run if the poetry.lock file has not been modified.

… main

- Set the default isolation_parameters in the tutorial notebook to microfaune parameters
- Updated environment test yaml file based on most recent changes from main
Copy link
Contributor

@JacobGlennAyers JacobGlennAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I'll go ahead and push the changes to main!

@JacobGlennAyers JacobGlennAyers merged commit 5d1fae8 into main May 5, 2024
3 checks passed
@JacobGlennAyers JacobGlennAyers deleted the template-matching branch May 5, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants