Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added min and max to the agg function #8

Merged
merged 1 commit into from
Aug 4, 2020
Merged

added min and max to the agg function #8

merged 1 commit into from
Aug 4, 2020

Conversation

cvanoli
Copy link
Collaborator

@cvanoli cvanoli commented Aug 3, 2020

Added the min() and max() operations to the make_agg_var function, to for example get the max_year_built in parcels.

smmaurer
smmaurer approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@smmaurer smmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

msoltadeo
msoltadeo approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@msoltadeo msoltadeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cvanoli cvanoli merged commit eccd7a1 into master Aug 4, 2020
@cvanoli cvanoli deleted the agg_max_min_ branch August 4, 2020 01:20
@smmaurer smmaurer mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msoltadeo msoltadeo msoltadeo approved these changes

@smmaurer smmaurer smmaurer approved these changes

@jessicacamacho jessicacamacho Awaiting requested review from jessicacamacho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvanoli @smmaurer @msoltadeo