feat(EMS-3709-10): code and test fixes

UK-Export-Finance · Aug 6, 2024 · 6c5bba9 · 6c5bba9
1 parent e32de81
commit 6c5bba9
Show file tree

Hide file tree

Showing 4 changed files with 84 additions and 96 deletions.
diff --git a/.../summary-list/check-your-answer-summary-list-contract-awarded-competitive-bidding.spec.js b/.../summary-list/check-your-answer-summary-list-contract-awarded-competitive-bidding.spec.js
@@ -21,37 +21,34 @@ const task = taskList.submitApplication.tasks.checkAnswers;
 
 const baseUrl = Cypress.config('baseUrl');
 
-context(
-  `Insurance - Check your answers - Export contract - Summary list - Contract awarded ${COMPETITIVE_BIDDING.TEXT} - As an exporter, I want to be able to review my input for the export contract again, So that I can do a final review of the information I previously input before submitting my application`,
-  () => {
-    let referenceNumber;
-    let url;
+context(`Insurance - Check your answers - Export contract - Summary list - Contract awarded with ${COMPETITIVE_BIDDING.TEXT}`, () => {
+  let referenceNumber;
+  let url;
 
-    before(() => {
-      cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
-        referenceNumber = refNumber;
+  before(() => {
+    cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
+      referenceNumber = refNumber;
 
-        cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedCompetitiveBidding: true });
+      cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedCompetitiveBidding: true });
 
-        task.link().click();
+      task.link().click();
 
-        // To get past previous "Check your answers" pages
-        cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
+      // To get past previous "Check your answers" pages
+      cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
 
-        url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
-      });
+      url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
     });
+  });
 
-    beforeEach(() => {
-      cy.saveSession();
+  beforeEach(() => {
+    cy.saveSession();
 
-      cy.navigateToUrl(url);
-    });
+    cy.navigateToUrl(url);
+  });
 
-    after(() => {
-      cy.deleteApplication(referenceNumber);
-    });
+  after(() => {
+    cy.deleteApplication(referenceNumber);
+  });
 
-    assertMinimalExportContractSummaryListRows({ awardMethodValue: COMPETITIVE_BIDDING.TEXT });
-  },
-);
+  assertMinimalExportContractSummaryListRows({ awardMethodValue: COMPETITIVE_BIDDING.TEXT });
+});
diff --git a/...ontract/summary-list/check-your-answer-summary-list-contract-awarded-direct-award.spec.js b/...ontract/summary-list/check-your-answer-summary-list-contract-awarded-direct-award.spec.js
@@ -21,37 +21,34 @@ const task = taskList.submitApplication.tasks.checkAnswers;
 
 const baseUrl = Cypress.config('baseUrl');
 
-context(
-  `Insurance - Check your answers - Export contract - Summary list - Contract awarded ${DIRECT_AWARD.TEXT} - As an exporter, I want to be able to review my input for the export contract again, So that I can do a final review of the information I previously input before submitting my application`,
-  () => {
-    let referenceNumber;
-    let url;
+context(`Insurance - Check your answers - Export contract - Summary list - Contract awarded with ${DIRECT_AWARD.TEXT}`, () => {
+  let referenceNumber;
+  let url;
 
-    before(() => {
-      cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
-        referenceNumber = refNumber;
+  before(() => {
+    cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
+      referenceNumber = refNumber;
 
-        cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedDirectAward: true });
+      cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedDirectAward: true });
 
-        task.link().click();
+      task.link().click();
 
-        // To get past previous "Check your answers" pages
-        cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
+      // To get past previous "Check your answers" pages
+      cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
 
-        url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
-      });
+      url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
     });
+  });
 
-    beforeEach(() => {
-      cy.saveSession();
+  beforeEach(() => {
+    cy.saveSession();
 
-      cy.navigateToUrl(url);
-    });
+    cy.navigateToUrl(url);
+  });
 
-    after(() => {
-      cy.deleteApplication(referenceNumber);
-    });
+  after(() => {
+    cy.deleteApplication(referenceNumber);
+  });
 
-    assertMinimalExportContractSummaryListRows({ awardMethodValue: DIRECT_AWARD.TEXT });
-  },
-);
+  assertMinimalExportContractSummaryListRows({ awardMethodValue: DIRECT_AWARD.TEXT });
+});
diff --git a/.../summary-list/check-your-answer-summary-list-contract-awarded-negotiated-contract.spec.js b/.../summary-list/check-your-answer-summary-list-contract-awarded-negotiated-contract.spec.js
@@ -21,37 +21,34 @@ const task = taskList.submitApplication.tasks.checkAnswers;
 
 const baseUrl = Cypress.config('baseUrl');
 
-context(
-  `Insurance - Check your answers - Export contract - Summary list - Contract awarded ${NEGOTIATED_CONTRACT.TEXT} - As an exporter, I want to be able to review my input for the export contract again, So that I can do a final review of the information I previously input before submitting my application`,
-  () => {
-    let referenceNumber;
-    let url;
+context(`Insurance - Check your answers - Export contract - Summary list - Contract awarded with ${NEGOTIATED_CONTRACT.TEXT}`, () => {
+  let referenceNumber;
+  let url;
 
-    before(() => {
-      cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
-        referenceNumber = refNumber;
+  before(() => {
+    cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
+      referenceNumber = refNumber;
 
-        cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedNegotiatedContract: true });
+      cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedNegotiatedContract: true });
 
-        task.link().click();
+      task.link().click();
 
-        // To get past previous "Check your answers" pages
-        cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
+      // To get past previous "Check your answers" pages
+      cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
 
-        url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
-      });
+      url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
     });
+  });
 
-    beforeEach(() => {
-      cy.saveSession();
+  beforeEach(() => {
+    cy.saveSession();
 
-      cy.navigateToUrl(url);
-    });
+    cy.navigateToUrl(url);
+  });
 
-    after(() => {
-      cy.deleteApplication(referenceNumber);
-    });
+  after(() => {
+    cy.deleteApplication(referenceNumber);
+  });
 
-    assertMinimalExportContractSummaryListRows({ awardMethodValue: NEGOTIATED_CONTRACT.TEXT });
-  },
-);
+  assertMinimalExportContractSummaryListRows({ awardMethodValue: NEGOTIATED_CONTRACT.TEXT });
+});
diff --git a/...ntract/summary-list/check-your-answers-summary-list-contract-awarded-other-method.spec.js b/...ntract/summary-list/check-your-answers-summary-list-contract-awarded-other-method.spec.js
@@ -22,37 +22,34 @@ const task = taskList.submitApplication.tasks.checkAnswers;
 
 const baseUrl = Cypress.config('baseUrl');
 
-context(
-  `Insurance - Check your answers - Export contract - Summary list - Contract awarded ${OTHER.TEXT} - As an exporter, I want to be able to review my input for the export contract again, So that I can do a final review of the information I previously input before submitting my application`,
-  () => {
-    let referenceNumber;
-    let url;
+context(`Insurance - Check your answers - Export contract - Summary list - Contract awarded with ${OTHER.TEXT}`, () => {
+  let referenceNumber;
+  let url;
 
-    before(() => {
-      cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
-        referenceNumber = refNumber;
+  before(() => {
+    cy.completeSignInAndGoToApplication({}).then(({ referenceNumber: refNumber }) => {
+      referenceNumber = refNumber;
 
-        cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedOtherMethod: true });
+      cy.completePrepareApplicationSinglePolicyType({ referenceNumber, contractAwardedOtherMethod: true });
 
-        task.link().click();
+      task.link().click();
 
-        // To get past previous "Check your answers" pages
-        cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
+      // To get past previous "Check your answers" pages
+      cy.completeAndSubmitMultipleCheckYourAnswers({ count: 3 });
 
-        url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
-      });
+      url = `${baseUrl}${INSURANCE_ROOT}/${referenceNumber}${EXPORT_CONTRACT}`;
     });
+  });
 
-    beforeEach(() => {
-      cy.saveSession();
+  beforeEach(() => {
+    cy.saveSession();
 
-      cy.navigateToUrl(url);
-    });
+    cy.navigateToUrl(url);
+  });
 
-    after(() => {
-      cy.deleteApplication(referenceNumber);
-    });
+  after(() => {
+    cy.deleteApplication(referenceNumber);
+  });
 
-    assertMinimalExportContractSummaryListRows({ awardMethodValue: application.EXPORT_CONTRACT[OTHER_AWARD_METHOD] });
-  },
-);
+  assertMinimalExportContractSummaryListRows({ awardMethodValue: application.EXPORT_CONTRACT[OTHER_AWARD_METHOD] });
+});