-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-3344): no PDF - application submission - XLSX - buyer #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iness - code/test improvements
…pany sic/date ordering
ttbarnes
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
chore
Chore
labels
May 30, 2024
Zainzzkk
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Chore
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the XLSX mapping sent during application submission so that the "Buyer" section is aligned with the latest no PDF/XLSX design:
Resolution ✔️
E2E directories
/application-submission/business-conditions/*.spec.js
/application-submission/buyer-conditions/*.spec.js
/application-submission/export-contract-conditions/*.spec.js
/application-submission/policy-conditions/*.spec.js
E2E commands
completeAlternativeCurrencyField
clickAlternativeCurrencyRadioAndCompleteCurrency
completeBuyerSection
and various other cypress commands to accept new params and conditionally submit an alternative buyer currency.E2E test coverage improvements
API alignments, helpers
CURRENCY
andYOUR_BUYER
field ID constants.YOUR_BUYER
content strings.VALIDATION
constants.FORM_TITLES
content strings.mapYesNoField
helper function to:defaultValue
.getPopulatedApplication
helper function return a fully populated buyer (buyer relationship, buyer trading history).API XLSX generation
DECLARATIONS
index inTITLE_INDEXES
.XLSX_ROW_INDEXES
to bump some particular indexes accordingly, depending on the conditional buyer answers.mapBuyer
XLSX function and create new mapping functions to generate new answers in no PDF:mapConnectionWithBuyer
mapBuyerTradingHistory
mapOutstandingPayments
mapPreviousCoverWithBuyer
Miscellaneous ➕
mockApplicationMinimalBrokerBuyerAndCompany
.test.yml
.getPopulatedApplication
unit tests to usetoThrow()