Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EMS-3471): no PDF - Account - Verify email expired link #2608

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(EMS-3471): no PDF - Account - Verify email expired link #2608

merged 1 commit into from
Jun 19, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented Jun 19, 2024 •
edited by ttbarnes
Loading

Introduction ✏️

This PR fixes an issue where the "verify email - expired link" was setting the URL as the container name.

Resolution ✔️

  • Changed to req.headers.origin
  • Updated test

@Zainzzkk Zainzzkk added the fix Fixes an existing issue label Jun 19, 2024
@Zainzzkk Zainzzkk self-assigned this Jun 19, 2024
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa June 19, 2024 11:04 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk merged commit 140f138 into main-application-no-pdf Jun 19, 2024
166 checks passed
@Zainzzkk Zainzzkk deleted the fix/EMS-3471 branch June 19, 2024 13:04
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
fix Fixes an existing issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes