Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-3532): no pdf - application submission - XLSX - worksheets #2654

Merged
merged 17 commits into from
Jul 2, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Jul 2, 2024

Introduction ✏️

This PR updates the XLSX generation so that each section of an application has it's on worksheet/tab in the XLSX, instead of single worksheet with a large list and a myriad of conditional index behaviours.

Resolution ✔️

  • Create new INDEXES constants for each section of an application.
  • Create new SECTION_NAMES constants.
  • Remove the original XLSX_ROW_INDEXES approach.
  • Update XLSX_HEADER_COLUMNS.
  • Update generate.XLSX to generate a worksheet for each section.
  • Update mapApplicationToXLSX to return an object structure.
  • Update worksheetRowHeights and styledColumns to work with worksheets instead of one single worksheet.

Miscellaneous ➕

  • Minor logging improvements.

@ttbarnes ttbarnes added documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements chore Chore labels Jul 2, 2024
@ttbarnes ttbarnes self-assigned this Jul 2, 2024
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes requested a deployment to qa July 2, 2024 14:28 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit 965e618 into main-application-no-pdf Jul 2, 2024
166 of 167 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-3532 branch July 2, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants