Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EMS-1269): no PDF - CRON - Submission deadline email #2670

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix(EMS-1269): no PDF - CRON - Submission deadline email #2670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1e90bb
fix(EMS-1269): fixed submission deadline email helper
Jul 2, 2024
625615a
fix(EMS-1269): added console.info
Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/api/.keystone/config.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions src/api/helpers/send-email-application-submission-deadline/send-email/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ describe('helpers/send-email-application-submission-deadline/send-email', () =>
expect(sendEmailSubmissionDeadlineSpy).toHaveBeenCalledTimes(1);
expect(sendEmailSubmissionDeadlineSpy).toHaveBeenCalledWith(variables.email, variables);
});

test('it should return an array of length 1', async () => {
const result = await applicationSubmissionDeadineEmail.send([application]);

expect(result.length).toEqual(1);
});
});

describe('error handling', () => {
Expand All @@ -56,9 +62,7 @@ describe('helpers/send-email-application-submission-deadline/send-email', () =>
});

test('should return success as false', async () => {
await expect(applicationSubmissionDeadineEmail.send([application])).rejects.toThrow(
'Sending application submission deadline email (sendEmail.submissionDeadlineEmail)',
);
await expect(applicationSubmissionDeadineEmail.send([application])).rejects.toThrow('Sending application submission deadline email (send helper)');
});
});
});
Expand Down
28 changes: 15 additions & 13 deletions src/api/helpers/send-email-application-submission-deadline/send-email/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,25 @@ import { Application, EmailResponse } from '../../../types';
* generates an array of promises to send submission deadline emails
* resolves all promises and logs the number of emails sent
* @param {Array<Application>} applications: Array of applications
* @returns {Promise<void>} application submission deadline emails sent
* @returns {Array<Promise>} application submission deadline emails sent
*/
const send = async (applications: Array<Application>) => {
const promises = applications.map(async (application) => {
const variables = mapApplicationSubmissionDeadlineVariables(application);
try {
console.info('Sending application submission deadline emails - send helper');

return sendEmail.submissionDeadlineEmail(variables.email, variables);
}) as Array<Promise<EmailResponse>>;
const mapped = applications.map(async (application) => {
const variables = mapApplicationSubmissionDeadlineVariables(application);

return Promise.all(promises)
.then((sent) => {
console.info('Application submission deadline emails sent: ', sent.length);
})
.catch((err) => {
console.error('Error sending application submission deadline email (sendEmail.submissionDeadlineEmail) %O', err);
throw new Error(`Sending application submission deadline email (sendEmail.submissionDeadlineEmail) ${err}`);
});
return sendEmail.submissionDeadlineEmail(variables.email, variables);
}) as Array<Promise<EmailResponse>>;

const promises = await Promise.all(mapped);

return promises;
} catch (err) {
console.error('Error sending application submission deadline email (send helper) %O', err);
throw new Error(`Sending application submission deadline email (send helper) ${err}`);
}
};

const applicationSubmissionDeadineEmail = {
Expand Down
Loading