-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-3828-3876): currency of agent charges - save and back, improve e2e assertions #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack functionality
…ncyFieldsFunction
ttbarnes
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
chore
Chore
labels
Sep 20, 2024
Zainzzkk
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Chore
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR adds "save and back" functionality to the "export contract - currency of agent charges" form.
Previously, the common currency forms did not have "save and back" functionality.
Therefore, as part of this feature, the DRY E2E currency form assertion functions needed some refactoring to support DRY "save and back" tests.
Resolution ✔️
formSubmissionAssertions
) so that:formSubmission({}).executeTests();
index
file, with previously existing functions extracted into their own files.assertCurrencyFormFields
to conditionally click submit or "Save and back" buttons.completeNonCurrencyFields
tocompleteNonCurrencyFieldsFunction
.SAVE_AND_BACK_URL
.Miscellaneous ➕