Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-3828-3876): currency of agent charges - save and back, improve e2e assertions #3101

Merged
merged 16 commits into from
Sep 26, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Sep 20, 2024

Introduction ✏️

This PR adds "save and back" functionality to the "export contract - currency of agent charges" form.

Previously, the common currency forms did not have "save and back" functionality.

Therefore, as part of this feature, the DRY E2E currency form assertion functions needed some refactoring to support DRY "save and back" tests.

Resolution ✔️

  • Update the E2E currency form assertion function (formSubmissionAssertions) so that:
    • It can be executed with 1x line of code, formSubmission({}).executeTests();
    • It handles high level describe blocks (instead of repeating in individual tests.
    • It tests "via continue/submit" and "via save/back" button scenarios.
    • The main file is now an index file, with previously existing functions extracted into their own files.
  • Update assertCurrencyFormFields to conditionally click submit or "Save and back" buttons.
  • Rename completeNonCurrencyFields to completeNonCurrencyFieldsFunction.
  • Update E2E tests.
  • Create "save and back" UI POST routes for "export contract - currency of agent charges"
  • Update "your buyer - currency of late payments" controllers to have a page variables funtion with SAVE_AND_BACK_URL.

Miscellaneous ➕

  • Add various missing documentation.
  • Fix some typos.

@ttbarnes ttbarnes added documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements chore Chore labels Sep 20, 2024
@ttbarnes ttbarnes self-assigned this Sep 20, 2024
@ttbarnes ttbarnes merged commit f9769ee into main-iterations Sep 26, 2024
179 of 180 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-3828-chore/EMS-3876 branch September 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants