Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13070 playwright version update issue in pipeline #122

Merged
merged 5 commits into from
Mar 31, 2022
Merged

13070 playwright version update issue in pipeline #122

merged 5 commits into from
Mar 31, 2022

Conversation

amogh14893
Copy link
Contributor

PR contains below changes which fixed failing FTs in deployment pipeline

  1. Changes to removed npm install and use npm ci instead, which in turn picked correct playwright version and dependencies from package-lock.json file
  2. Resolved vulnerabilities and Build issues.

@amogh14893 amogh14893 requested review from rockydevnet and a team as code owners March 31, 2022 06:08
crdandoukho
crdandoukho approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@crdandoukho crdandoukho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amogh, your changes are exactly what I was hoping for.

@crdandoukho crdandoukho merged commit 1836494 into main Mar 31, 2022
@crdandoukho crdandoukho deleted the Feature/13070-playwright-version-update-issue-in-pipeline branch March 31, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crdandoukho crdandoukho crdandoukho approved these changes

@bhalcha13813 bhalcha13813 Awaiting requested review from bhalcha13813

@rockydevnet rockydevnet Awaiting requested review from rockydevnet rockydevnet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amogh14893 @crdandoukho @rashmish24