Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/13069 fss UI only display filters where there is more than 1 attribute value #126

Conversation

prasad14878
Copy link
Contributor

No description provided.

@@ -93,77 +93,81 @@ describe('Test Search Result Scenario On Simplified Search Page', () => {
expect(fileDownloadStatus).toContain("check");
})

it('Verify search results specific batch attributes on filter panel', async () => {
it('Verify search results specific batch attributes Not displayed on filter panel', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this test to Verify batch attributes with single value are not displayed on filter panel

Suggested change
it('Verify search results specific batch attributes Not displayed on filter panel', async () => {
it('Verify batch attributes with single value are not displayed on filter panel', async () => {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved. Thanks

Copy link
Contributor

@crdandoukho crdandoukho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@bhalcha13813 bhalcha13813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crdandoukho
Copy link
Contributor

@prasad14878 @kajalkundu could you please resolve the merge conflicts?

@crdandoukho crdandoukho merged commit 4515be2 into main Apr 14, 2022
@crdandoukho crdandoukho deleted the Feature/13069-FSS-UI-Only-display-filters-where-there-is-more-than-1-attribute-value branch April 14, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants