[fix
] Handle out of range values in scalar quantization
#2865
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
This PR addresses an issue with out-of-range values during scalar quantization. Previously, when quantizing data, values outside the calibration range could result in incorrect quantization.
Solution
The PR fixes this issue by introducing a clip operation in the quantization process. This operation ensures that quantized values are correctly bounded within the expected range, thus preventing out-of-range values from producing incorrect results.
Example
Result:
incorrect quantized values for the first and third entries, respectively, which are outside the calibration range.
After the PR:
The quantized values are correctly bounded and thus match the expected output.