Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an ImportError to tell the user that datasets must be install to fit a model #3020

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

h4c5
Copy link
Contributor

@h4c5 h4c5 commented Oct 24, 2024

Minor change to add an ImportError when datasets is not installed and the user try to fit a model ( Closes #3019 )

@tomaarsen
Copy link
Collaborator

Well spotted! Apologies for the slight delay.
I hadn't noticed this myself as model.fit is the old way of finetuning a model, nowadays the Trainer is preferred: https://sbert.net/docs/sentence_transformer/training_overview.html

I do still want to merge this though - it'll help those who still want to use the old approach or still have scripts for model.fit.

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 96a4bd7 into UKPLab:master Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an error to tell the user datasets is required to fit a model
2 participants