Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Remove evaluation_steps from model.fit test without evaluator #3037

Merged

Conversation

tomaarsen
Copy link
Collaborator

Follow-up from #3035

Hello!

Pull Request overview

  • Remove evaluation_steps from model.fit test without evaluator

Details

Using evaluation_steps sets args.eval_strategy, which now throws an error with transformers >=v4.46.0 and #3035 if you don't have an evaluation dataset nor an evaluator.

  • Tom Aarsen

As this now results in an error in Transformers 4.46.0
@tomaarsen tomaarsen merged commit 7d99ca9 into UKPLab:master Nov 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant