refactor: move llm bots to separate package #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
UMA-1702 Create a separate package for llm-bot in protocol repo
Move the llm-bot from packages/monitor-v2 to a separate package packages/llm-bot |
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
5 tasks
mrice32
approved these changes
Aug 31, 2023
| @@ -0,0 +1,24 @@ | |||
| import { formatBytes32String, parseUnits } from "./utils"; | |||
There was a problem hiding this comment.
Are some/all of these test utilities files copied? If so, could you comment that in the PR so we know which to review as fresh code?
packages/llm-bot/src/utils/logger.ts
Outdated
| const optimisticOracleV2UIBaseUrl = "https://oracle.uma.xyz"; | ||
| const testnetOptimisticOracleV2UIBaseUrl = "https://testnet.oracle.uma.xyz"; | ||
|
|
||
| // monitor-v2 package is only using Optimistic Oracle V3, so currently there is no need to generalize this. |
packages/llm-bot/src/utils/logger.ts
Outdated
Comment on lines
13
to
28
| export const createSnapshotProposalLink = (baseUrl: string, space: string, proposalId: string): string => { | ||
| return `<${baseUrl}/#/${space}/proposal/${proposalId}|Snapshot UI>`; | ||
| }; | ||
|
|
||
| export const createTenderlySimulationLink = (simulationResult?: TenderlySimulationResult): string => { | ||
| if (simulationResult === undefined) { | ||
| return "No Tenderly simulation available"; | ||
| } else if (simulationResult.status) { | ||
| return `<${simulationResult.resultUrl.url}|Tenderly simulation successful${ | ||
| !simulationResult.resultUrl.public ? " (private)" : "" | ||
| }>`; | ||
| } else { | ||
| return `<${simulationResult.resultUrl.url}|Tenderly simulation reverted${ | ||
| !simulationResult.resultUrl.public ? " (private)" : "" | ||
| }>`; | ||
| } |
There was a problem hiding this comment.
Was a little surprised to see this code here? Is this used (or placed to be used) in the LLC bit codebase? If so, no problem, just wanted to call it out!
daywiss
approved these changes
Aug 31, 2023
Signed-off-by: Pablo Maldonado <pablo@umaproject.org>
md0x
deleted the
pablo/uma-1702-create-a-separate-package-for-llm-bot-in-protocol-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Move LLM bots to a separate package