Refactor config methods. now single method returns boolean for erb

app/presenters/show_presenter.rb

@@ -2,37 +2,18 @@
 
 class ShowPresenter < Blacklight::ShowPresenter
 
-  def test_field
-    arr = [ "type_ssi", "format_ssim", "sp_physical_format_ssi" ]
-    # arr = [ "country_ssi", "sp_country_ssi", "continent_ssi", "sp_continent_ssi" ]
-    # does the document have anything in the array / check if array contains any or all ? . .
-    # document['country_ssi'].present? # just returns true or false
-    # arr.include?('continent_ssi')
-    # document.include?(document['continent_ssi']) # this does not work. can't access document like an array
-    arr.each do |field|
-      return document[field].present? # returns boolean if fields in the document are present in the arr array
-    end
-  end
-
-  def test_arr
-    arr = configuration.show_fields.to_a
+  def type_arr
     new_arr =[]
-    arr.each do |item| 
-      new_arr.push(item[0])
+
+    configuration.show_fields.to_a.each do |item| 
+      if item[1][:type]==:primary
+        new_arr.push(item[0])
+      end
     end
-    new_arr
-    # new_arr.each do |field|
-    #   return document[field].present? # returns boolean if fields in the document are present in the arr array
-    # end
-  end
 
-  def type_arr
-    arr = configuration.show_fields.to_a
-    new_arr =[]
-    arr.each do |item| 
-      new_arr.push(item[1][:type])
+    new_arr.each do |field|   # returns boolean if any field in new_arr is present in the document
+      return document[field].present? 
     end
-    new_arr
   end
 
   def each_primary_field
@@ -47,8 +28,4 @@ def each_secondary_field
     end
   end
 
-  def render_field?(field_config)
-    field_presenter(field_config).render_field? and has_value? field_config
-  end
-
 end

app/views/catalog/_show.html.erb

@@ -27,15 +27,11 @@
 <% doc_presenter = document_presenter(document) %>
 <hr>
 
-<%= doc_presenter.test_field==true ? "Details" : "" %> 
 <% doc_presenter.each_primary_field do |field_name, field, field_presenter| %>
   <%= render "show_fields", document: document, field: field, field_name: field_name, field_presenter: field_presenter %>
 <% end -%>
 
-
-<%= doc_presenter.test_field==true ? "Details" : "" %>
-<%= doc_presenter.test_field %>
-
+<%= doc_presenter.type_arr==true ? "Details" : "" %>
 <% doc_presenter.each_secondary_field do |field_name, field, field_presenter| %>
   <%= render "show_fields", document: document, field: field, field_name: field_name, field_presenter: field_presenter %>
 <% end -%>