-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BXC-3284 add controller and service files #1622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ageService3 class, which does not appear to have a @context attribute
bbpennel
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good over all, just some cleanup
...ices-app/src/main/java/edu/unc/lib/boxc/web/services/processing/ImageServerProxyService.java
Show resolved
Hide resolved
...ervices-app/src/main/java/edu/unc/lib/boxc/web/services/rest/ImageServerProxyController.java
Outdated
Show resolved
Hide resolved
web-services-app/src/test/resources/image-server-proxy-servlet.xml
Outdated
Show resolved
Hide resolved
...ervices-app/src/main/java/edu/unc/lib/boxc/web/services/rest/ImageServerProxyController.java
Show resolved
Hide resolved
bbpennel
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a controller and service file for the image server proxy (which will currently be Cantaloupe) but hopefully in the future we can switch it to any other server.
https://unclibrary.atlassian.net/browse/BXC-3284