BXC-4216 - Patron Role/Permission for accessing reduced quality images #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…role. Remove unused methods. Add test coverage. Refactor roles to inherit permissions from each other, since almost all of them build off another role
…ucedResImages is granted, and only show full size and original when viewOriginals granted. Update tests to include new permission
… CdrAcl property. Add additional tests to verify new permission works during evaluation and setting
…ow res or original) then the download button will appear instead of the restricted content block. Add additional restrictedContent tests to verify this, check the dropdown has the right options, and some refactoring to DRY up code
…ra test to verify new permission works in patron settings
bbpennel
force-pushed
the
bxc-4316-lowres
branch
from
87d8bf9 to
e6372f6
Compare
bbpennel
force-pushed
the
bxc-4316-lowres
branch
from
e6372f6 to
02fa14e
Compare
lfarrell
reviewed
Jan 11, 2024
| <a class="button view action" :href="recordData.dataFileUrl"> | ||
| <i class="fa fa-search" aria-hidden="true"></i> View</a> | ||
| </div> | ||
| <template v-if="hasPermission(recordData, 'viewOriginal')"> |
There was a problem hiding this comment.
You should be able to put the v-if on <div class="actionlink">. I'm not sure why I did it this way, but it's not a big deal either way.
lfarrell
approved these changes
Jan 11, 2024
…umber of templates in restrictedContent.vue based on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/BXC-4316