Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BXC-4780 - Handling hung kakadu processes #28

Merged
merged 5 commits into from
Nov 6, 2024
Merged

BXC-4780 - Handling hung kakadu processes #28

merged 5 commits into from
Nov 6, 2024

Conversation

bbpennel
Copy link
Member

@bbpennel bbpennel commented Nov 6, 2024

https://unclibrary.atlassian.net/browse/BXC-4783

  • All subprocess calls will now timeout after 5 minutes
    • output read in parallel now, otherwise the timeouts would cause a deadlock. Also capturing error output separate from standard output when writing output to files.
  • Images that are GrayscaleAlpha but have RGB data will have the alpha channel removed, as this was causing kakadu to get stuck forever on certain images
  • Adds some custom error classes

bbpennel and others added 4 commits November 6, 2024 10:51
@bbpennel
Allow commands to timeout. Read output and error in parallel to waiti…
e103647 
…ng, otherwise it can deadlock. Add specialized command exceptions and adjust error handling
@bbpennel
Add special case handling of images that are grayscale alpha but cont…
479d49c 
…ain rgb data, which was causing kakadu to hang forever
@bbpennel
Trim imageType
79a382c
@krwong
fix tests
50b40b6
@bbpennel bbpennel merged commit db37bca into main Nov 6, 2024
1 check passed
@bbpennel bbpennel deleted the bxc-4783 branch November 6, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krwong krwong krwong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bbpennel @krwong