Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Generalization of defaceTpl to post_op #225

Merged
merged 8 commits into from
Jul 5, 2023

Conversation

arnaudbore
Copy link
Contributor

@arnaudbore arnaudbore commented Jul 4, 2023

defaceTpl is back from the dead with a really nice feature that will allow people to add their favorite post script right before moving their data to BIDS.

#188

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #225 (d42f137) into master (14f9143) will decrease coverage by 2.08%.
The diff coverage is 32.65%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   80.15%   78.07%   -2.08%     
==========================================
  Files          15       15              
  Lines         927      967      +40     
  Branches      181      197      +16     
==========================================
+ Hits          743      755      +12     
- Misses        146      170      +24     
- Partials       38       42       +4     
Flag Coverage Δ
pytest 78.07% <32.65%> (-2.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dcm2bids/dcm2bids_gen.py 79.51% <30.00%> (+1.87%) ⬆️
dcm2bids/sidecar.py 77.69% <31.57%> (-7.31%) ⬇️
dcm2bids/utils/utils.py 83.51% <100.00%> (ø)

... and 1 file with indirect coverage changes

@arnaudbore arnaudbore changed the title [ENH] Generalization of defaceTpl to postOp [ENH] Generalization of defaceTpl to post_op Jul 4, 2023
@arnaudbore arnaudbore mentioned this pull request Jul 4, 2023
@arnaudbore arnaudbore merged commit 178a51a into UNFmontreal:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants