Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only lint on push to main #128

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Only lint on push to main #128

merged 1 commit into from
Jul 12, 2024

Conversation

fcooper8472
Copy link
Collaborator

Prevent the workflow running twice every time a push updates a PR.

Otherwise the workflow runs twice for every push that updates a PR, because it runs for the PR and for the push
Copy link
Collaborator

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this turn off the checks in PRs? (I ask cause there are no checks on your PR)

@fcooper8472
Copy link
Collaborator Author

does this turn off the checks in PRs? (I ask cause there are no checks on your PR)

No: it will still check on PR, but, the check is only triggered if a *.md file is changed, which is why it didn't run on this PR.

@fcooper8472
Copy link
Collaborator Author

I really should get Alasdair to review this one, but it looks like he's not in the organisation!

Copy link
Collaborator

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh ok :)

@martinjrobins martinjrobins merged commit fedcae7 into main Jul 12, 2024
@martinjrobins martinjrobins deleted the lint-branch-main branch July 12, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants