-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piloted and revised Foundational HPC course #187
base: main
Are you sure you want to change the base?
Conversation
Update from upstream repo
Update from upstream
Update from upstream
Thanks @steve-crouch, I can see those link errors arn't coming from your changes, so happy to ignore these! I'll try to get a review done asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reviewing this in detail but I initially had just a general thought on the layout, I think the high performance computing theme is organised incorrectly.
The "Theme" page has too much specificity in it, take for comparison the technology and tooling theme where one course is on say "IDEs" and another on "Testing" to the HPC theme where one course is on "Parallel Computing" and another is on "Introduction to parallelism" and another on "Introduction to supercomputing". I know this is not all added in this PR though.
There would still need to be work to do to get the rest of the Theme in line and these 4 "streams" could be linked together in the theme diagram too which would not be represented in the default gridbox layout.
For example openmp and MPI would be merged into a single "course" called something like "parallel computing tooling" or "parallel computing libraries" with the openmp and mpi as separate streams.
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the mega-review, and for submitting it early by accident, but there you go anyway...
I am happy to leave reorganising the sections for a follow up PR, but I do think the HPC theme needs something done to keep it manageable.
high_performance_computing/computer_simulations/02_weather_simulations.md
Outdated
Show resolved
Hide resolved
high_performance_computing/computer_simulations/02_weather_simulations.md
Show resolved
Hide resolved
high_performance_computing/computer_simulations/02_weather_simulations.md
Outdated
Show resolved
Hide resolved
high_performance_computing/computer_simulations/02_weather_simulations.md
Outdated
Show resolved
Hide resolved
high_performance_computing/computer_simulations/03_towards_future.md
Outdated
Show resolved
Hide resolved
high_performance_computing/computer_simulations/03_towards_future.md
Outdated
Show resolved
Hide resolved
high_performance_computing/computer_simulations/03_towards_future.md
Outdated
Show resolved
Hide resolved
high_performance_computing/computer_simulations/03_towards_future.md
Outdated
Show resolved
Hide resolved
Apologies @steve-crouch for both the insane amount of suggestions and the fact I accidentally submitted the review part way (meaning some future comments got added as single comments rather than the review) Anyway, done now 👍 |
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ulations.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ulations.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ulations.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ulations.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ulations.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ure.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ure.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ure.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ure.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
…ulations.md Co-authored-by: Alasdair Wilson <60351846+alasdairwilson@users.noreply.github.com>
Many thanks for the very comprehensive review, @alasdairwilson! The suggestions were excellent in simplifying and clarifying the text. I've reviewed and (I hope, given the scale of the review comments) accepted all changes. I've also fixed the content's textual references to the prior week-based schedule from the original content (#199) as you suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there are 2 markdown lint errors:
These changes should fix them.
|
||
A supercomputer is a computer with very high-level computational capacities, significantly surpassing a general-purpose computer such as a personal desktop or laptop. | ||
|
||
Supercomputers were first introduced in the 1960s by Seymour Roger Cray at Control Data Corporation (CDC), and have been used intensively in science and engineering ever since. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supercomputers were first introduced in the 1960s by Seymour Roger Cray at Control Data Corporation (CDC), and have been used intensively in science and engineering ever since. | |
Supercomputers were first introduced in the 1960s by Seymour Roger Cray at Control Data Corporation (CDC), and have been used intensively in science and engineering ever since. |
Supercomputers were first introduced in the 1960s by Seymour Roger Cray at Control Data Corporation (CDC), and have been used intensively in science and engineering ever since. | ||
Clearly the technology has improved since then - today’s laptop would have been a supercomputer only a couple of decades ago - but no matter how fast today’s general-purpose computers are, there will always be a need for much more powerful machines. | ||
To keep track of the state-of-the-art, the supercomputing community looks to the Top500 list, which ranks the fastest 500 supercomputers in the world every six months. | ||
### Number crunching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Number crunching | |
### Number crunching |
So there are actually like 190 more review comments or something you have to hit the load more to get 20 at a time (or go through the whole review on the changes tab but that's probably more of a pain). that goes for both the reviews: and which has 9 or so. If you are willing to accept them all then you can just "add them to batch" one at a time rather than commiting them directly and then commit when finished, which is a bit easier. I am not a maintainer on this repo sadly so can't take away the pain. |
A piloted and revised Foundational HPC course based on material from EPCC's Intro to HPC course, comprised of 4 modules.