Updates to OpenMP/MPI Materials Based on August Pilot Feedback #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are covering OpenMP, MPI and Parallelisation sessions.
… note about omp.h
…ed loops callout with collapse clause, fixed scheduler terminology, and addressed firstprivate caveat. Also fixed typos.
…, expanded and clarified scheduler explanations, added compilable atomic example, new section on reduction clauses with examples, and clarified nested region restrictions. Fixed issues with synchronization routines, race condition explanation, and thread-specific matrix updates. Addressed indentation, typos, and other minor improvements.
…addressed buffer initialisation issues, and improved explanations for MPI concepts.
…essed rank-specific behaviours, added link for derived types episode, and explained matching in collective comms
Post-Pilot Updates for MPI Episodes
Post pilot OpenMP updates
abhidg
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Hi @mehtaparabaci looks good! Few minor comments for improvement and some typos.
high_performance_computing/hpc_mpi/04_point_to_point_communication.md
Outdated
Show resolved
Hide resolved
high_performance_computing/hpc_mpi/04_point_to_point_communication.md
Outdated
Show resolved
Hide resolved
high_performance_computing/hpc_mpi/05_collective_communication.md
Outdated
Show resolved
Hide resolved
high_performance_computing/hpc_mpi/11_advanced_communication.md
Outdated
Show resolved
Hide resolved
high_performance_computing/hpc_mpi/11_advanced_communication.md
Outdated
Show resolved
Hide resolved
Fixed typo
… data type challenge
|
Thanks for the review & feedback @abhidg! I've made the updates-let me know if anything else needs tweaking. |
abhidg
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Hi @mehtaparabaci - all looks good, except for s/INT_TYPE/DATA_TYPE
| #define MPI_DATA_TYPE MPI_INT | ||
| #define DATA_TYPE int | ||
| // use them as you would normally | ||
| INT_TYPE my_data = 1; |
There was a problem hiding this comment.
Good catch @abhidg! Just updated-thanks!
Changed INT_TYPE to DATA_TYPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from the OpenMP/MPI pilot in August, we’ve updated the course materials to fix errors, clarify concepts, and add examples to make the lessons easier to follow.
OpenMP
collapseclauses, andreductionwere clarified with new explanations and examples.barriers.c,matrix_update.c) and updates to the corresponding textsMPI
MPI_STATUS_IGNOREand clarifiedMPI_Broadcastmatching send/receive requirements.