Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

165 frontend move header to the correct location #166

Merged
merged 71 commits into from
Apr 12, 2024

Conversation

thienguen
Copy link
Contributor

@thienguen thienguen commented Mar 31, 2024

What type of PR is this? (Check all that apply)

  • feature: Introduces completely new code or new features.
  • 🐛fix: Implements changes that fix a bug. Ideally, reference an issue if present.
  • ♻️refactor: Includes any code-related change that is neither a fix nor a feature.
  • build: Encompasses all changes related to the build of the software, including changes to dependencies or the addition of new ones.
  • ⚡️test: Pertains to all changes regarding tests, whether adding new tests or modifying existing ones.
  • 🚰ci: Involves all changes related to the configuration of continuous integration, such as GitHub Actions or other CI systems.
  • 📚docs: Includes all changes to documentation, such as README files, or any other documentation present in the repository.
  • 🗑️chore: Captures all changes to the repository that do not fit into the above categories.

Description

What did you change? How did you change it?

  1. remove shadcn entirely
  2. ci/cd for API (currently on halt, since we yet to write test for the)
  3. dashboard structure, inbox structure, workout structure, and friends structure
  4. TUI turbo (experimental features, T side quest)
  5. fixed TRPC typed,
  6. fixed vitest in API packages, and jest
  7. have a development build
  8. deploy on the web (through expo)
  9. prettier config fixed to single quote
  10. bug: bottom sheet for gorhom, so making my own Pick Modal
  11. bug: nativewind is incomplete, that's why we have issue with tailwind not apply to some components. Current components that's known will break (SafeViewArea, TouchOpacity)
  12. Android build now use Java 17 instead of Java 11.
  13. expo SDK is 50 (previously 49)
  14. added fonts (Sora, IstokWeb) -- through tailwind or style is fine
  15. We are on latest of everything

Tests

How was this tested?

  • Unit tests
  • Integration tests
  • E2E tests
  • Manual tests
  • Tests were NOT needed
  • Other (explain below)

1. build, and versions control

  • since tons of versions had been done by me, to accommodate for bugs that keep breaking from legacy code, I would need you to pnpm clean:workspaces to clean the entire workspaces node_module
  • pnpm i x3 (for safety)
  • bb1 && bb2 that good stuff
  • ensure you can run this app through both expo and development build of ios (android it's fine)
  • tips: delete the .ios folder so that it build fresh
  • (optional) -- for android build, also delete .android folder and look at this StackOverflow to setup your SDK
  • i can't test on ios, so if someone can do that would be great

image

  • You will need to install new expo into virtual device

2. ui changed and structure proposed

  • at first landed, you go on this

image

  • the plus icon now have this instead (there is other animation (play around and see which you prefer) -- IN ADDITION, I have a cook animation for that, so i will cook it next pr.

image

--> see video (can't attach here since it's too large)

image

  • Propose structure of our app, next issue I will organize others stuff. They start clutter up our spaces.

3. misc

  • Open any files that has double quote, those in workout tracker folder is a good place to test
  • format document (vscode it is shift + alt + r, or just execute your format on save setting

image

  • how do we know it has run the formatted? --> check output (ctrl + shift + u)

image

  • cd packages/api run pnpm run vitest

image

  • in api folder, also try pnpm run vitest-ui

image

  • that is our backend testing for api (vitest is daway, I found jest to be slow af for me)
  • imma need some man powers to write unit tests here, I'm doing designs and features.

@thienguen thienguen linked an issue Mar 31, 2024 that may be closed by this pull request
4 tasks
@thienguen thienguen closed this Mar 31, 2024
@thienguen thienguen reopened this Mar 31, 2024
@thienguen thienguen closed this Mar 31, 2024
@thienguen thienguen reopened this Mar 31, 2024
@thienguen thienguen closed this Mar 31, 2024
@thienguen thienguen reopened this Apr 10, 2024
@thienguen thienguen self-assigned this Apr 10, 2024
@thienguen thienguen added bug Something isn't working enhancement New feature or request frontend design, visual added build ci/cd or dependencies related labels Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c6bf4b6) to head (491b778).

Additional details and impacted files
@@             Coverage Diff              @@
##             main      #166       +/-   ##
============================================
+ Coverage   76.21%   100.00%   +23.78%     
============================================
  Files          22        24        +2     
  Lines         164       148       -16     
  Branches       40        32        -8     
============================================
+ Hits          125       148       +23     
+ Misses         39         0       -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thienguen
Copy link
Contributor Author

thienguen commented Apr 10, 2024

Fall over from cycle 7, no 8?

@mva919
Copy link
Contributor

mva919 commented Apr 10, 2024

92 FILESSSS!!!????
image

@thienguen thienguen requested a review from mva919 April 10, 2024 20:18
Copy link
Contributor

@mva919 mva919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both android and ios and it works on development build, I just added a comment for a to do that we need to do. 🚀

@thienguen
Copy link
Contributor Author

Tested on both android and ios and it works on development build, I just added a comment for a to do that we need to do. 🚀

tysm ✨

@thienguen
Copy link
Contributor Author

thank you for reviewing once again @mva919

@thienguen thienguen merged commit dc665a0 into main Apr 12, 2024
3 checks passed
@thienguen thienguen deleted the 165-frontend-move-header-to-the-correct-location branch April 12, 2024 03:16
@thienguen thienguen changed the title 165 frontend headers, layouts and bugs Frontend -- Layouts Headers and bugs Apr 13, 2024
@thienguen thienguen changed the title Frontend -- Layouts Headers and bugs 165 frontend move header to the correct location Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build ci/cd or dependencies related enhancement New feature or request frontend design, visual added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend -- move header to the correct location
2 participants