-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
165 frontend move header to the correct location #166
165 frontend move header to the correct location #166
Conversation
and added fonts, a shit tons of it
This reverts commit 80d1940.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
============================================
+ Coverage 76.21% 100.00% +23.78%
============================================
Files 22 24 +2
Lines 164 148 -16
Branches 40 32 -8
============================================
+ Hits 125 148 +23
+ Misses 39 0 -39 ☔ View full report in Codecov by Sentry. |
Fall over from cycle 7, no 8? |
seed prod
…tps://github.com/UNLV-CS472-672/2024-S-GROUP3-Barbell into 165-frontend-move-header-to-the-correct-location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on both android and ios and it works on development build, I just added a comment for a to do that we need to do. 🚀
tysm ✨ |
thank you for reviewing once again @mva919 |
What type of PR is this? (Check all that apply)
Description
What did you change? How did you change it?
ci/cd
for API (currently on halt, since we yet to write test for the)dashboard structure, inbox structure, workout structure, and friends structure
TUI turbo
(experimental features, T side quest)TRPC
typed,vitest
in API packages, and jestdevelopment build
expo
)prettier
config fixed tosingle quote
gorhom
, so making my own Pick Modalnativewind
is incomplete, that's why we have issue with tailwind not apply to some components. Current components that's known will break (SafeViewArea
,TouchOpacity
)Android
build now useJava 17
instead of Java 11.expo SDK
is 50 (previously 49)Sora, IstokWeb
) -- through tailwind or style is fineTests
How was this tested?
1. build, and versions control
pnpm clean:workspaces
to clean the entire workspacesnode_module
pnpm i
x3 (for safety)bb1 && bb2
that good stuffexpo
anddevelopment build
of ios (android it's fine)tips
: delete the.ios
folder so that it build freshandroid
build, also delete.android
folder and look at this StackOverflow to setup your SDK2. ui changed and structure proposed
--> see video (can't attach here since it's too large)
3. misc
cd packages/api
runpnpm run vitest
api
folder, also trypnpm run vitest-ui