Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

190 frontend start existing workout functionality #201

Merged
merged 9 commits into from
Apr 14, 2024

Conversation

L-Hen
Copy link
Contributor

@L-Hen L-Hen commented Apr 12, 2024

What type of PR is this? (Check all that apply)

  • feature: Introduces completely new code or new features.
  • 🐛fix: Implements changes that fix a bug. Ideally, reference an issue if present.
  • ♻️refactor: Includes any code-related change that is neither a fix nor a feature.
  • build: Encompasses all changes related to the build of the software, including changes to dependencies or the addition of new ones.
  • ⚡️test: Pertains to all changes regarding tests, whether adding new tests or modifying existing ones.
  • 🚰ci: Involves all changes related to the configuration of continuous integration, such as GitHub Actions or other CI systems.
  • 📚docs: Includes all changes to documentation, such as README files, or any other documentation present in the repository.
  • 🗑️chore: Captures all changes to the repository that do not fit into the above categories.

Description

What did you change? How did you change it?
Added functionality to Start Existing Workout page + work on exercise list.

Tests

How was this tested?

  • Unit tests
  • Integration tests
  • E2E tests
  • Manual tests
  • Tests were NOT needed
  • Other (explain below)

[Optional] Screenshots

image

Documentation

  • Added to README.me
  • Seperate document
  • NO documentation needed

Link to external documentation:

[Optional] Are there any post-deployment tasks we need to perform?

Add functionality to the next button and pass the desired workout to the next page.

@L-Hen L-Hen linked an issue Apr 12, 2024 that may be closed by this pull request
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (db8c1d0) to head (3db569c).

❗ Current head 3db569c differs from pull request most recent head b63d5d8. Consider uploading reports for the commit b63d5d8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          148       149    +1     
  Branches        32        33    +1     
=========================================
+ Hits           148       149    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

</TouchableOpacity>)}
</ScrollView>

return (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clean 👍

@thienguen
Copy link
Contributor

Selected workout should highlight and should be sent to the following page when clicking "next"? This is implemented, right?

@taylorfinelli
Copy link
Contributor

@thienguen not yet

@thienguen
Copy link
Contributor

@taylorfinelli will it be done in this pr, or that would be henry next issue?

@thienguen thienguen added the frontend design, visual added label Apr 13, 2024
@mva919
Copy link
Contributor

mva919 commented Apr 14, 2024

I will be taking it over

@thienguen
Copy link
Contributor

lgtnm

@thienguen
Copy link
Contributor

@L-Hen @taylorfinelli sync w main and I can hit the merge

Copy link
Contributor

@mva919 mva919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be nice if you added unit tests with your new files.

@thienguen thienguen merged commit b7321a7 into main Apr 14, 2024
1 check failed
@thienguen thienguen deleted the 190-frontend-start-existing-workout-functionality branch April 14, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend design, visual added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend -- Start Existing Workout Functionality
5 participants