-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
190 frontend start existing workout functionality #201
190 frontend start existing workout functionality #201
Conversation
Switch code to correct file. Styled some more.
…-frontend-start-existing-workout-functionality
Still need to add search bar, list of exercises, and select exercise to next page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 148 149 +1
Branches 32 33 +1
=========================================
+ Hits 148 149 +1 ☔ View full report in Codecov by Sentry. |
…s with workoutList.tsx
</TouchableOpacity>)} | ||
</ScrollView> | ||
|
||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is clean 👍
Selected workout should highlight and should be sent to the following page when clicking "next"? This is implemented, right? |
@thienguen not yet |
@taylorfinelli will it be done in this pr, or that would be henry next issue? |
I will be taking it over |
lgtnm |
@L-Hen @taylorfinelli sync w main and I can hit the merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would be nice if you added unit tests with your new files.
What type of PR is this? (Check all that apply)
Description
What did you change? How did you change it?
Added functionality to Start Existing Workout page + work on exercise list.
Tests
How was this tested?
[Optional] Screenshots
Documentation
Link to external documentation:
[Optional] Are there any post-deployment tasks we need to perform?
Add functionality to the next button and pass the desired workout to the next page.