Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expo android & ios folders from repo #58

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

elliotwesoff
Copy link
Contributor

What type of PR is this? (Check all that apply)

  • feature: Introduces completely new code or new features.
  • 🐛fix: Implements changes that fix a bug. Ideally, reference an issue if present.
  • ♻️refactor: Includes any code-related change that is neither a fix nor a feature.
  • build: Encompasses all changes related to the build of the software, including changes to dependencies or the addition of new ones.
  • ⚡️test: Pertains to all changes regarding tests, whether adding new tests or modifying existing ones.
  • 🚰ci: Involves all changes related to the configuration of continuous integration, such as GitHub Actions or other CI systems.
  • 📚docs: Includes all changes to documentation, such as README files, or any other documentation present in the repository.
  • 🗑️chore: Captures all changes to the repository that do not fit into the above categories.

Description

The apps/expo/{android,ios} folders are build/dev environment specific according to platform. They should be created/populated/changed automatically according to your individual workflow and platform. It shouldn't be necessary to have them committed to the repo. They take up a lot of space and account for large diffs when they are automatically changed.

Tests

How was this tested?

  • Unit tests
  • Integration tests
  • E2E tests
  • Manual tests
  • Tests were NOT needed
  • Other (explain below)

Explanation:

Documentation

  • Added to README.me
  • Seperate document
  • NO documentation needed

Link to external documentation:

[Optional] Screenshots

[Optional] Are there any post-deployment tasks we need to perform?

Additional notes

@elliotwesoff elliotwesoff requested review from thienguen and removed request for taylorfinelli March 8, 2024 18:40
@taylorfinelli
Copy link
Contributor

Works on my end and runs in iOS 17.2.
Pinging @mva919 since he just added the iOS files into the expo yesterday. Maybe he can take a better look than me.

@thienguen thienguen merged commit 2404b03 into main Mar 8, 2024
@thienguen thienguen deleted the chore/expo-cleanup branch March 8, 2024 19:05
@thienguen thienguen added the bug Something isn't working label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants