Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quiz page #31

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Added quiz page #31

merged 2 commits into from
Mar 21, 2024

Conversation

Alexmc567
Copy link
Contributor

Overview

Added basic functionality for quiz page

Related Issue(s)

Missing quiz page - This should be closed after this is merged

Changes

Added basic functionality to the quiz page.

Added

Added QuizPage.js
Added QuizPage.module.css

Screenshots

Capture

The full quiz should now be completable. Clicking on an answer will change it to green to signify your choice. Clicking next will unselect your option and display the next question.

Instructions for Testing

Clone the repo
Go to app
npm install
npm start
navigate to http://localhost:3000/quiz

Checklist before Merging

  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • I have ensured the changes adhere to the project's coding standards and guidelines.

Additional Comments

Current issues:
Scores do not add up correctly
Additionally, I hard coded the total possible points temporarily, as I just wanted to get the quiz page up as soon as possible if other people want to work on it.

@Alexmc567
Copy link
Contributor Author

I just noticed the other pull request before this one - Since we both modified App.js will I need to reupload my pull request after the other one is merged? (New to github, not sure if thats how that works)

@dusek2
Copy link
Contributor

dusek2 commented Mar 20, 2024

Pull Request Review checklist

  • Readability:
    • Read the PR description. Does it align with the proposed changes?
    • Check if the code is clear and the logic is easy to follow.

Answer: Code readable and logic

  • Code Quality:
    • Are there comments explaining complex sections of code?
    • Is the programming style consistent with the project's standards?

Answer: Consistent code and comments included

  • Testing:
    • Is Test coverage still >90%
    • Did code pass Github Actions CI system's pass all tests?

Answer: Test coverage still not 90% we need to work on it this week.

  • Functionality:
    • Are all changes backward compatible?
    • Does the PR resolve an existing issue?

Answer: yes

  • Housekeeping:
    • Are all files committed free from unnecessary (e.g., logs,
      temporary files)?
    • Has any assistance from Generative AI been linked to PR or commented
      below?

Answer:files cleared, no assistance

Additional Comments:

Answer:

@barkangel
Copy link
Contributor

barkangel commented Mar 21, 2024

I fixed the merge conflict. I added your 2 new quiz lines as well as my 2 quest page lines to App.js. It was possible to do in GitHub by clicking "Resolve Conflicts" and modifying the file to include said lines

Copy link
Contributor

@barkangel barkangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review checklist

  • Readability:

    • Pull Request description matches proposed changes. Code is easy to understand and the logic is easy to follow
  • Code Quality:

    • Comments explain the sections of code, complex and simple. Programming style is consistent with the Javascript standards of the program.
  • Testing:

    • Test coverage is not high, but that is OK for now. Github Actions CI system passed all tests.
  • Functionality:

  • Housekeeping:

    • Files are free from unnecessary temporary files and logs and other framework generated files. AI is not linked, thus assumed not used.
  • Additional Comments:

    • Good screenshot of quiz page. I suggest a different font for future use.
    • PR good to merge!

@DillonDavidson DillonDavidson merged commit d04c69e into main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants