-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added quiz page #31
Added quiz page #31
Conversation
I just noticed the other pull request before this one - Since we both modified App.js will I need to reupload my pull request after the other one is merged? (New to github, not sure if thats how that works) |
Pull Request Review checklist
Answer: Code readable and logic
Answer: Consistent code and comments included
Answer: Test coverage still not 90% we need to work on it this week.
Answer: yes
Answer:files cleared, no assistance Additional Comments:Answer: |
I fixed the merge conflict. I added your 2 new quiz lines as well as my 2 quest page lines to App.js. It was possible to do in GitHub by clicking "Resolve Conflicts" and modifying the file to include said lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Review checklist
-
Readability:
- Pull Request description matches proposed changes. Code is easy to understand and the logic is easy to follow
-
Code Quality:
- Comments explain the sections of code, complex and simple. Programming style is consistent with the Javascript standards of the program.
-
Testing:
- Test coverage is not high, but that is OK for now. Github Actions CI system passed all tests.
-
Functionality:
- Yes, changes backward compatible. PR resolves existing issue Missing quiz page #32 which is good to close.
-
Housekeeping:
- Files are free from unnecessary temporary files and logs and other framework generated files. AI is not linked, thus assumed not used.
-
Additional Comments:
- Good screenshot of quiz page. I suggest a different font for future use.
- PR good to merge!
Overview
Added basic functionality for quiz page
Related Issue(s)
Missing quiz page - This should be closed after this is merged
Changes
Added basic functionality to the quiz page.
Added
Added QuizPage.js
Added QuizPage.module.css
Screenshots
The full quiz should now be completable. Clicking on an answer will change it to green to signify your choice. Clicking next will unselect your option and display the next question.
Instructions for Testing
Clone the repo
Go to app
npm install
npm start
navigate to http://localhost:3000/quiz
Checklist before Merging
Additional Comments
Current issues:
Scores do not add up correctly
Additionally, I hard coded the total possible points temporarily, as I just wanted to get the quiz page up as soon as possible if other people want to work on it.