Removed game_scene.gd dependency #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edited map_scene.tscn so it would stop requiring deleted file map_scene.gd
barkangel
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Pull Request Review:
Readability: Code readable and easy to understand
Code Quality: Code is good, fixed deletion of unused file.
Testing: We need to implement coverage test into CI workflow
Functionality: Code is more functional now than previous PR with bug.
Housekeeping: Good, PR fixes bug in last pr.
Pull Request Review:Readability: Code is just as readable as before minus a few removed buggy lines. Code Quality: Same code, one bug squashed. Testing: Still needs test file. Functionality: Code fixed a bug. Housekeeping: No extra files, just some line changes. No AI mentioned. |
thegreatzoidberg
approved these changes
Mar 24, 2024
vicliyj
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Pull Request Review Checklist:
- Readability: Code is easy to read!
- Code Quality: Quality is still good with these changes.
- Testing: Definitely need to add some more test coverage.
- Functionality: Great catch with this bug.
- Housekeeping: Everything is high quality, easy to read, and easy to follow!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bug Fix. Edited map_scene.tscn so it would stop requiring deleted file map_scene.gd
Related Issue(s)
closes #41
Changes
Describe in detail the changes made in this pull request. Include specifics about modifications to files, added or removed functionalities, and any other changes that contributors and reviewers should be aware of.
Added
N/A
Changed
Modified map_scene.tscn to not longer require map_scene.gd
Removed
Removed map_scene.tscn dependency on deleted file map_scene.gd
Fixed
Error Loading map_scene.tscm missing requirements map_scene.gd
Screenshots
Instructions for Testing
Open Godot and load map_scene.tscm
Checklist before Merging
Additional Comments
Include any additional comments or context that you think might be helpful for the reviewers.