Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding navigation button linking #54

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Adding navigation button linking #54

merged 4 commits into from
Mar 26, 2024

Conversation

dusek2
Copy link
Contributor

@dusek2 dusek2 commented Mar 26, 2024

Overview

Simple PR adding linking to navigation buttons forwarding to their respective pages

Related Issue(s)

Closes #53

Changed

  • app/src/components/BackButton.js
  • app/src/components/GameButton.js
  • app/src/components/NavigationPanel.js

Instructions for Testing

npm run start
localhost:3000

Checklist before Merging

  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • I have ensured the changes adhere to the project's coding standards and guidelines.

Copy link
Contributor

@vicliyj vicliyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review:

  • Readability: Code is easy to read and understand
  • Code Quality: Easy to understand and follow
  • Testing: Looks good!
  • Functionality: Also looks good.

Copy link
Contributor

@barkangel barkangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review:

  • Readability: Easily understandable and readable code
  • Code Quality: Code in javascript easy to follow with react components
  • Testing: Good features that can be used for more unit tests down the line.
  • Functionality: Good, well needed addition keeping the project well rounded and functional.

Additional Comments:

  • Watch for merge conflicts with recent pull request merges
  • Approved!

@dusek2 dusek2 merged commit 2c1138a into UNLV-CS472-672:main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link navigation buttons between pages
3 participants