Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting Home and App.js unit tests, increasing coverage 49% -> 59% #68

Merged
merged 5 commits into from
Mar 31, 2024

Conversation

dusek2
Copy link
Contributor

@dusek2 dusek2 commented Mar 31, 2024

Overview

Increasing test coverage and removing skeleton form routing.

Changes

  • Fixed issues with Github Actions for Home and App.js tests

Changed

  • app/src/App.js
  • app/src/components/TopPanel.js
  • app/src/tests/AppJs.test.js
  • app/src/tests/AppJs.test.js

Screenshots

image

Instructions for Testing

npm run test
npm run coverage

Checklist before Merging

  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • I have ensured the changes adhere to the project's coding standards and guidelines.

@dusek2
Copy link
Contributor Author

dusek2 commented Mar 31, 2024

@dusek2
Copy link
Contributor Author

dusek2 commented Mar 31, 2024

All checks have passed

@dusek2 dusek2 changed the title Adjusting Home and App.js unit tests, increasing coverage 49% -> 50% Adjusting Home and App.js unit tests, increasing coverage 49% -> 59% Mar 31, 2024
Copy link
Contributor

@MoldyPotat MoldyPotat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review:

Readability: 

Everything is well named and easy to follow.

Code Quality:

Code is of good quality adding more testing in an understandable manner.

Testing:

Increases testing closer to where it should be.

Functionality:

Increases testing coverage and set some of the page links to navigate to correct page.

Additional Comments:
AI uses noted in pr.

@thegreatzoidberg
Copy link
Contributor

Pull Request Review:

  • Readability:

    • Easy to read and has comments.
  • Code Quality:

    • Code looks like it works. Fixed some bugs with the original files.
  • Testing:

    • More tests added and modified files pass all tests.
  • Functionality:

    • More testing was added and App doesn't lead to skeleton anymore.
  • Housekeeping:

    • No junk files, ChatGPT was used and conversation was linked.

Additional Comments:

@thegreatzoidberg thegreatzoidberg merged commit 3000de9 into UNLV-CS472-672:main Mar 31, 2024
1 check passed
@dusek2 dusek2 deleted the fixHome branch April 16, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants