Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more unit tests index.js, skeleton.js #70

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

dusek2
Copy link
Contributor

@dusek2 dusek2 commented Apr 2, 2024

Overview

Increasing test coverage to reach our CI goal

Related Issue(s)

Related to #24

Added

  • app/src/tests/Skeleton.test.js
  • app/src/tests/index.test.js

Instructions for Testing

npm run coverage

Checklist before Merging

  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • I have ensured the changes adhere to the project's coding standards and guidelines.

@dusek2
Copy link
Contributor Author

dusek2 commented Apr 2, 2024

Passed CI tests

@dusek2
Copy link
Contributor Author

dusek2 commented Apr 2, 2024

image

Copy link
Contributor

@barkangel barkangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review:

Readability:

  • Index, Skeleton, and Back Button tests look great. Very easy to understand.

Code Quality:

  • Tests utilize a similar structure, allowing for ease of understanding.
  • data-testid's useful and follow a similar implementation scheme that I and others have implemented in other tests such as quest page and quiz page.

Testing:

  • Test files included as main component of PR.

Functionality:

  • Code passes CI Workflow actions

Additional Comments:

  • woo 69% lines tested! very good improvement from a week ago.

@thegreatzoidberg
Copy link
Contributor

Pull Request Review:

Readability:

  • Code spaced out well and has comments. I'd say add more comments but I don't know where I would put them.

Code Quality:

  • Code doesn't look like it has any bugs in them.

Testing:

  • Two more test files, bumps us up to 69.41%.
  • Rest of modified files pass Workflow.

Functionality:

  • More test coverage plus small modifications to already existing files.

Housekeeping:

  • No junk files, no AI mentioned.

Additional Comments:

  • Should probably cross off the 4 checklist items if you've already done them.

@thegreatzoidberg thegreatzoidberg merged commit 1bb7973 into UNLV-CS472-672:main Apr 4, 2024
1 check passed
@dusek2 dusek2 deleted the indexTest branch April 16, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants