-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MongoDB database connection and first APIs for user data #79
Conversation
ChatGPT assistance used on Unit tests on user data API |
Test coverage is over 80% but not yet implemented into Github Actions, I have to look into how to use APIs in Github Actions. It means we need the backend running and connected to database with secret URI and also the tests running simultaneously |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Review:
Readability:
The code does as is stated in the PR. The current code implemented is logical and makes sense and is easy to follow.
Code Quality:
Comments are included and the code fits the current structure of our project.
Testing:
Test coverage is over 80% but is yet to implemented in GitHub actions. I have created issue #81 for this.
Functionality:
Changes are backward compatible and solve #75.
Housekeeping:
All AI use has been documented.
Additional Comments:
Huge job on creating basic API requests for user schemas in our database. Good job also including testing and adding a .env file for our connection code. Approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Review:
Readability:
Code is easy to follow and easy to read, files have respective changes listed in PR.
Code Quality:
Code is written well, no overflow, and documentation is present.
Functionality:
Solves issue #75. and code is necessary for testing and backend connections.
Housekeeping:
Documentation is very good. ChatGPT4 is used, and documented where used.
Additional Comments:
Great work with testing percentage as well as backend connection. Great work, and a huge help bringing all aspects of the project together. A good transition into the backend stage of our webapp development.
Comments are very helpful and appreciated when connecting to backend.
PR approved and merging good to go!
Overview
Creating MongoDB connection and an API to add, retrieve and delete user from database
Related Issue(s)
Closes #76
Changes
Created mongo connection in app.js of backend.
Created users.js routing for database APIs
Implemented usage of .env to hide database access URI
Changed login.js to remove database connection and move to app.js instead
Added
Changed
Screenshots
Mongo DB record
Test coverage over 80%
Instructions for Testing
After cloning repo
Checklist before Merging