-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional login page test #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like there is something failing in the workflow!
Sorry about that, I was testing something else but I forgot to use a new branch. I reverted the commits so now the tests will pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Review:
- Readability: Easy to follow and understand!
- Quality: Looks good!
- Functionality: Added unit test for login page.
- Housekeeping: AI use noted down where it was used, comments in place for what code does.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Review:
Readability: Code is easy to read and understand
Quality: Quality of pull request is good, nice job
Functionality: Included a test for the added changes
Housekeeping: Comments added designating where AI was used for code generation.
Good job Fernando!
Overview
Added additional tests to the login page. The last thing big test that needs to be added is the function test. This will need #81 to be resolved first.
Changes
Test 'renders without crashing' is more thorough now.
Added
Test 'input field updates value with current input' added to test input fields and see if they are updating values appropriately.
Changed
General comments added for clarity.
Instructions for Testing
See GitHub Actions tab.
Checklist before Merging
Additional Comments
Assistance from ChatGPT 3.5 used. Appropriate annotations used.
Conversation here: https://chat.openai.com/share/025568dc-22e7-4567-8d68-6e1a6b5b9cf8.
Slight modifications for my user case and testing of both input fields.