Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new scene for each level in game #93

Merged
merged 10 commits into from
Apr 16, 2024
Merged

Conversation

vicliyj
Copy link
Contributor

@vicliyj vicliyj commented Apr 15, 2024

Overview

Created an individual/independent scene, with corresponding scripts, for each level. Each button in the level selection page will lead to their own game scene depending on which one the user selects.

Related Issue(s)

Closes #92

Changes

Added new game scenes for every level that didn't have their own. Renamed some old scenes to match naming scheme of new ones and to prevent confusion with other similarly named scenes/scripts.

Added

  • level_two.tscn : Bare game scene for level 2
  • level_two.gd : Bare script for level 2
  • level_three.tscn : Bare game scene for level 3
  • level_three.gd : Bare script for level 3
  • Level2.gd : New script for "Level 2" option in map_scene
  • Level3.gd : New script for "Level 3" option in map_scene

Changed

  • Renamed game_scene.tscn to level_one.tscn
  • Small housekeeping, deleting extra empty lines

Screenshots

level_one.tscn
image
level_two.tscn
image
level_three.tscn
image

Instructions for Testing

  1. Run project on Godot
  2. Press "Play" to navigate to level selection
  3. Press "Level 1", then click "Yes." Scene should display the level number on the top left of the screen.
  4. Press "Setting" in the top right corner, then "Levels" to return to level selection.
  5. Repeat from step 3 to test "Level 2" and "Level 3"

Checklist before Merging

  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • I have ensured the changes adhere to the project's coding standards and guidelines.

Additional Comments

Scripts for buttons in map_scene (Level1.gd) may have to be renamed in the future to avoid future confusion. Or game level scripts (level_one.gd) may have to be renamed.

@thegreatzoidberg
Copy link
Contributor

Pull Request Review:

  • Readability:

    • Level gd files are readable thanks to comments and obvious naming scheme.
    • Is it possible to rename the files in Game/LifeQuest to match the files in Game/LifeQuest/Scripts/MapScene?
      • 'level_name' -> 'Leveln'
      • Or maybe 'level_name' -> 'game_scene_n'?
  • Code Quality:

    • I don't see any problems in this code.
  • Testing:

    • No test files added (still need to fix the pipeline to work with gd files)
    • The levels load on Godot.
  • Functionality:

    • More sample levels added. Now we know having more than one level is possible.
  • Housekeeping:

    • No junk files, no AI mentioned.

Additional Comments:

  • Very nice! Could you edit level 2 and 3 a little though? Like add some things so it's easier to tell which level we're looking at?

Copy link
Contributor

@Ruben14789 Ruben14789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Review:

Readability:
    Level file scheme is easy to follow as they follow a pattern. comments included to make the code easier to understand 


Code Quality:
    Adds new scenes for each game level. 

Testing:
    screenshots show the addition of 3 levels indicating they are different by showing which level they are on the top left.

Functionality:
    Adds more levels to the game

Housekeeping:
    No AI mentioned.

Additional Comments:

@vicliyj vicliyj merged commit f3c377f into UNLV-CS472-672:main Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Levels in map_scene lead to same game level
3 participants