-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a new scene for each level in game #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Review:
Additional Comments:
|
thegreatzoidberg
approved these changes
Apr 15, 2024
Ruben14789
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Review:
Readability:
Level file scheme is easy to follow as they follow a pattern. comments included to make the code easier to understand
Code Quality:
Adds new scenes for each game level.
Testing:
screenshots show the addition of 3 levels indicating they are different by showing which level they are on the top left.
Functionality:
Adds more levels to the game
Housekeeping:
No AI mentioned.
Additional Comments:
Unlv cs472 672 main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Created an individual/independent scene, with corresponding scripts, for each level. Each button in the level selection page will lead to their own game scene depending on which one the user selects.
Related Issue(s)
Closes #92
Changes
Added new game scenes for every level that didn't have their own. Renamed some old scenes to match naming scheme of new ones and to prevent confusion with other similarly named scenes/scripts.
Added
Changed
Screenshots
level_one.tscn
level_two.tscn
level_three.tscn
Instructions for Testing
Checklist before Merging
Additional Comments
Scripts for buttons in map_scene (Level1.gd) may have to be renamed in the future to avoid future confusion. Or game level scripts (level_one.gd) may have to be renamed.