Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level Completion Tracking Array #95

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

thegreatzoidberg
Copy link
Contributor

Overview

  • Added Level Completion Tracking Array to PlayerInventory.gd. Will be used to allow/disallow level selection.

Related Issue(s)

Changes

  • Added Level Completion Tracking Array to PlayerInventory.gd

Added

  • Level Completion now tracked under PlayerInventory.gd

Changed

  • Modified PlayerInventory.gd

Checklist before Merging

  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • I have ensured the changes adhere to the project's coding standards and guidelines.

Additional Comments

  • To actually close Issue Add Level Progression #80, I still need to make it so completing a level increments the count and allows the user to go to the next one.

Copy link
Contributor

@Ruben14789 Ruben14789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability:
Easy to follow additions made

Code Quality:
Adds a way to keep track of level progression

Testing:
Adds a array in code

Functionality:
Adds a method to keep track of levels

Housekeeping:
No AI mentioned.

Copy link
Contributor

@MoldyPotat MoldyPotat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability: Easy to follow code.

Code Quality: Adds level progression system. Code seems simple and high quailty

Testing:

Functionality: Adds level progression system

Housekeeping: No bloat and everything in order. No AI mentioned.

Copy link
Contributor

@MoldyPotat MoldyPotat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve conflicts.

@thegreatzoidberg thegreatzoidberg merged commit 07a401d into UNLV-CS472-672:main Apr 16, 2024
1 check passed
@thegreatzoidberg thegreatzoidberg deleted the LevelTracking branch April 16, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants